Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Update eslint to version 3.5.0 🚀 #692

Merged
merged 6 commits into from Sep 21, 2016
Merged

Conversation

greenkeeperio-bot
Copy link
Contributor

Hello lovely humans,

eslint just published its new version 3.5.0.

State Update 🚀
Dependency eslint
New version 3.5.0
Type dependency

This version is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of eslint.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project ✨

You rock!

🌴


GitHub Release

  • 08fa538 Update: fix false negative of arrow-spacing (fixes #7079) (#7080) (Toru Nagashima)
  • cec65e3 Update: add fixer for no-floating-decimal (fixes #7070) (#7081) (not-an-aardvark)
  • 2a3f699 Fix: Column number for no-multiple-empty-lines (fixes #7086) (#7088) (Ian VanSchooten)
  • 6947299 Docs: Add info about closing accepted issues to docs (fixes #6979) (#7089) (Kai Cataldo)
  • d30157a Docs: Add link to awesome-eslint in integrations page (#7090) (Vitor Balocco)
  • 457be1b Docs: Update so issues are not required (fixes #7015) (#7072) (Nicholas C. Zakas)
  • d9513b7 Fix: Allow linting of .hidden files/folders (fixes #4828) (#6844) (Ian VanSchooten)
  • 6d97c18 New: max-len: ignoreStrings+ignoreTemplateLiterals (fixes #5805) (#7049) (Jordan Harband)
  • 538d258 Update: make no-implicit-coercion support autofixing. (fixes #7056) (#7061) (Eli White)
  • 883316d Update: add fixer for prefer-arrow-callback (fixes #7002) (#7004) (not-an-aardvark)
  • 7502eed Update: auto-fix for comma-style (fixes #6941) (#6957) (Gyandeep Singh)
  • 645dda5 Update: add fixer for dot-notation (fixes #7014) (#7054) (not-an-aardvark)
  • 2657846 Fix: no-console ignores user-defined console (fixes #7010) (#7058) (Toru Nagashima)
  • 656bb6e Update: add fixer for newline-before-return (fixes #5958) (#7050) (Vitor Balocco)
  • 1f995c3 Fix: no-implicit-coercion string concat false positive (fixes #7057) (#7060) (Kai Cataldo)
  • 6718749 Docs: Clarify that es6 env also sets ecmaVersion to 6 (#7067) (Jérémie Astori)
  • e118728 Update: add fixer for wrap-regex (fixes #7013) (#7048) (not-an-aardvark)
  • f4fcd1e Update: add more indent options for functions (fixes #6052) (#7043) (not-an-aardvark)
  • 657eee5 Update: add fixer for new-parens (fixes #6994) (#7047) (not-an-aardvark)
  • ff19aa9 Update: improve max-statements-per-line message (fixes #6287) (#7044) (Jordan Harband)
  • 3960617 New: prefer-numeric-literals rule (fixes #6068) (#7029) (Annie Zhang)
  • fa760f9 Chore: no-regex-spaces uses internal rule message format (fixes #7052) (#7053) (Kevin Partington)
  • 22c7e09 Update: no-magic-numbers false negative on reassigned vars (fixes #4616) (#7028) (not-an-aardvark)
  • be29599 Update: Throw error if whitespace found in plugin name (fixes #6854) (#6960) (Jesse Ostrander)
  • 4063a79 Fix: Rule message placeholders can be inside braces (fixes #6988) (#7041) (Kevin Partington)
  • 52e8d9c Docs: Clean up sort-vars (#7045) (Matthew Dunsdon)
  • 4126f12 Chore: Rule messages use internal rule message format (fixes #6977) (#6989) (Kevin Partington)
  • 46cb690 New: no-restricted-properties rule (fixes #3218) (#7017) (Eli White)
  • 00b3042 Update: Pass file path to parse function (fixes #5344) (#7024) (Annie Zhang)
  • 3f13325 Docs: Add kaicataldo and JamesHenry to our teams (#7039) (alberto)
  • 8e77f16 Update: new-parens false negative (fixes #6997) (#6999) (Toru Nagashima)
  • 326f457 Docs: Add missing 'to' in no-restricted-modules (#7022) (Oskar Risberg)
  • 8277357 New: line-comment-position rule (fixes #6077) (#6953) (alberto)
  • c1f0d76 New: lines-around-directive rule (fixes #6069) (#6998) (Kai Cataldo)
  • 61f1de0 Docs: Fix typo in no-debugger (#7019) (Denis Ciccale)
  • 256c4a2 Fix: Allow separate mode option for multiline and align (fixes #6691) (#6991) (Annie Zhang)
  • a989a7c Docs: Declaring dependency on eslint in shared config (fixes #6617) (#6985) (alberto)
  • 6869c60 Docs: Fix minor typo in no-extra-parens doc (#6992) (Jérémie Astori)
  • 28f1619 Docs: Update the example of SwitchCase (#6981) (fish)

The new version differs by 310 commits .

  • 18be52e 3.5.0
  • 8ff28c6 Build: package.json and changelog update for 3.5.0
  • 08fa538 Update: fix false negative of arrow-spacing (fixes #7079) (#7080)
  • cec65e3 Update: add fixer for no-floating-decimal (fixes #7070) (#7081)
  • 2a3f699 Fix: Column number for no-multiple-empty-lines (fixes #7086) (#7088)
  • 6947299 Docs: Add info about closing accepted issues to docs (fixes #6979) (#7089)
  • d30157a Docs: Add link to awesome-eslint in integrations page (#7090)
  • 457be1b Docs: Update so issues are not required (fixes #7015) (#7072)
  • d9513b7 Fix: Allow linting of .hidden files/folders (fixes #4828) (#6844)
  • 6d97c18 New: max-len: ignoreStrings+ignoreTemplateLiterals (fixes #5805) (#7049)
  • 538d258 Update: make no-implicit-coercion support autofixing. (fixes #7056) (#7061)
  • 883316d Update: add fixer for prefer-arrow-callback (fixes #7002) (#7004)
  • 7502eed Update: auto-fix for comma-style (fixes #6941) (#6957)
  • 645dda5 Update: add fixer for dot-notation (fixes #7014) (#7054)
  • 2657846 Fix: no-console ignores user-defined console (fixes #7010) (#7058)

There are 250 commits in total. See the full diff.


This pull request was created by greenkeeper.io.

Tired of seeing this sponsor message? ⚡ greenkeeper upgrade

@Arcanemagus
Copy link
Member

Arcanemagus commented Sep 9, 2016

Things to handle when updating:

Needs at least v1.14.0 to satisfy the peerDependency of eslint-config-airbnb-base.
Atom v1.10.0 was the first version to include a version of APM that could install `eslint@3`.
@Arcanemagus
Copy link
Member

Looks like the warnIgnored flag is CLIEngine only, which for some bizarre reason we aren't using here so we can't use that.

@Arcanemagus
Copy link
Member

Note that according to eslint/eslint#3307 (comment) no rules actually currently return a range, so testing that isn't possible without some contrived things like making our own eslint rule.

@IanVS
Copy link
Member

IanVS commented Sep 20, 2016

This looks great, @Arcanemagus! My only real concern is adding untested support for endLine and endColumn. They're not directly related to upgrading to ESLint 3.5.0, so as a matter of procedure they'd probably be better to add in a subsequent PR. Would you be terribly opposed to pulling that commit (10481ac) into another PR, and perhaps waiting until we can find a rule which supports it before we merge it? Other than that, I'm perfectly happy getting this merged.

@Arcanemagus
Copy link
Member

Sure, I can pull that out 😉.

@Arcanemagus
Copy link
Member

Split that out into #709.

@Arcanemagus Arcanemagus merged commit 6505411 into master Sep 21, 2016
@Arcanemagus Arcanemagus deleted the greenkeeper-eslint-3.5.0 branch September 21, 2016 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants