Update: add fixer for no-floating-decimal (fixes #7070) #7081
Conversation
|
@not-an-aardvark, thanks for your PR! By analyzing the annotation information on this pull request, we identified @vitorbal, @ilyavolodin and @nzakas to be potential reviewers |
|
LGTM |
kaicataldo
added
do not merge
|
Not sure why CI failed; it seems like it was a timeout issue unrelated to this change. |
|
Restarted CI manually. LGTM, that's was an easy fix:-) |
|
LGTM, just waiting another day for others to look. |
| context.report({ | ||
| node, | ||
| message: "A trailing decimal point can be confused with a dot.", | ||
| fix: fixer => fixer.insertTextAfter(node, "0") |
There was a problem hiding this comment.
Hmm. Though it's not related to this PR, this rule seems to miss 2.e+3-like notation originally.
Is it a bug?
There was a problem hiding this comment.
I'm not sure it is-- the rule is specifically about decimal points being confused for dot operators, I think, and so a decimal point in the middle of a numeric literal (even if it is on the trailing each of the mantissa) should be okay.
There was a problem hiding this comment.
I got it, thank you for the explanation!
LGTM.
nzakas
removed
the
evaluating
eslint-deprecated
bot
added
the
archived due to age
What issue does this pull request address?
#7070
What changes did you make? (Give an overview)
This adds an autofixer for the
no-floating-decimalrule.Is there anything you'd like reviewers to focus on?
Nothing in particular. #7070 has not been marked as accepted yet, so this PR should not be merged before that happens.