Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Clarify that es6 env also sets ecmaVersion to 6 #7067

Merged
merged 1 commit into from Sep 7, 2016

Conversation

astorije
Copy link
Contributor

@astorije astorije commented Sep 7, 2016

What issue does this pull request address?

None, this is a documentation-only pull request.

What changes did you make? (Give an overview)

Reading the docs, it is not clear why ESLint's parser will stop complaining about ES6 specifics when es6 env is set and ecmaVersion: 6 is omitted.
It is actually done on purpose, but the documentation didn't mention this at all.

Is there anything you'd like reviewers to focus on?

N/A

@eslintbot
Copy link

Thanks for the pull request, @astorije! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.
  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

Reading the docs, it is not clear why ESLint's parser will stop complaining about ES6 specifics when `es6` env is set and `ecmaVersion: 6` is omitted.
It is actually done [on purpose](https://github.com/eslint/eslint/blob/e1187285f137d685bcfc9e2a771fa059ef9637a9/conf/environments.js#L98-L103), but the documentation didn't mention this at all.
@eslintbot
Copy link

LGTM

@ilyavolodin
Copy link
Member

Thanks for PR!

@ilyavolodin ilyavolodin merged commit 6718749 into eslint:master Sep 7, 2016
@platinumazure
Copy link
Member

Oh drat, I was going to ask if clarification might be needed for non-default parsers (which may not use ecmaVersion at all).

@ilyavolodin Do we need to talk about non-default parsers here? Maybe not, but wanted to ask.

@ilyavolodin
Copy link
Member

I don't think we need to. We don't really focus on other parsers anywhere in our documentation. While we say we support them, I feel like if you choose any parser other than default, that sort of voids your warranty in regards to documentation:-)

@astorije astorije deleted the patch-2 branch September 7, 2016 14:26
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants