New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no-implicit-conversion should not warn on "" + "foo" #7057
Labels
accepted
There is consensus among the team that this change meets the criteria for inclusion
archived due to age
This issue has been archived; please open a new issue for any further discussion
bug
ESLint is working incorrectly
rule
Relates to ESLint's core rules
Comments
Just to be clear, the issue here is that there is no conversion because the other operand is definitely the same type? |
kaicataldo
added
bug
ESLint is working incorrectly
rule
Relates to ESLint's core rules
accepted
There is consensus among the team that this change meets the criteria for inclusion
and removed
triage
An ESLint team member will look at this issue soon
labels
Sep 5, 2016
Seems like a bug to me, given that no coercion is happening. Confirmed locally. |
kaicataldo
added a commit
that referenced
this issue
Sep 5, 2016
kaicataldo
added a commit
that referenced
this issue
Sep 5, 2016
@platinumazure yep, exactly. |
kaicataldo
added a commit
that referenced
this issue
Sep 5, 2016
kaicataldo
added a commit
that referenced
this issue
Sep 5, 2016
kaicataldo
added a commit
that referenced
this issue
Sep 5, 2016
kaicataldo
added a commit
that referenced
this issue
Sep 5, 2016
kaicataldo
added a commit
that referenced
this issue
Sep 5, 2016
kaicataldo
added a commit
that referenced
this issue
Sep 5, 2016
kaicataldo
added a commit
that referenced
this issue
Sep 5, 2016
kaicataldo
added a commit
that referenced
this issue
Sep 5, 2016
kaicataldo
added a commit
that referenced
this issue
Sep 6, 2016
kaicataldo
added a commit
that referenced
this issue
Sep 6, 2016
kaicataldo
added a commit
that referenced
this issue
Sep 6, 2016
kaicataldo
added a commit
that referenced
this issue
Sep 6, 2016
kaicataldo
added a commit
that referenced
this issue
Sep 6, 2016
eslint-deprecated
bot
added
the
archived due to age
This issue has been archived; please open a new issue for any further discussion
label
Feb 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
accepted
There is consensus among the team that this change meets the criteria for inclusion
archived due to age
This issue has been archived; please open a new issue for any further discussion
bug
ESLint is working incorrectly
rule
Relates to ESLint's core rules
What version of ESLint are you using?
3.4.0
What parser (default, Babel-ESLint, etc.) are you using?
default
Please show your full configuration:
Running the test suite
What did you do? Please include the actual source code causing the issue.
I added a test that the following should be valid:
and ran
What did you expect to happen?
I expected these to be valid
What actually happened? Please include the actual, raw output from ESLint.
eslint was fine with
1 * 1
but not with"" + "foo"
.While both of these aren't very good patterns for people to be following, there is nothing happening with type conversion here and thus
no-implicit-conversion
should not care about these cases.The text was updated successfully, but these errors were encountered: