Update: Throw error if whitespace found in plugin name (fixes #6854) (#…

…6960)
eslint · Sep 3, 2016 · be29599 · be29599
1 parent 4063a79
commit be29599
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 0 deletions.
diff --git a/lib/config/plugins.js b/lib/config/plugins.js
@@ -114,6 +114,16 @@ module.exports = {
             longName = pluginNamespace + PLUGIN_NAME_PREFIX + pluginNameWithoutPrefix;
         let plugin = null;
 
+        if (pluginName.match(/\s+/)) {
+            const whitespaceError = new Error("Whitespace found in plugin name '" + pluginName + "'");
+
+            whitespaceError.messageTemplate = "whitespace-found";
+            whitespaceError.messageData = {
+                pluginName: longName
+            };
+            throw whitespaceError;
+        }
+
         if (!plugins[shortName]) {
             try {
                 plugin = require(longName);

diff --git a/messages/whitespace-found.txt b/messages/whitespace-found.txt
@@ -0,0 +1,3 @@
+ESLint couldn't find the plugin "<%- pluginName %>". because there is whitespace in the name. Please check your configuration and remove all whitespace from the plugin name.
+
+If you still can't figure out the problem, please stop by https://gitter.im/eslint/eslint to chat with the team.
diff --git a/tests/lib/config/plugins.js b/tests/lib/config/plugins.js
@@ -85,6 +85,21 @@ describe("Plugins", function() {
             assert.deepEqual(Rules.get("example/qux"), plugin.rules.qux);
         });
 
+        it("should throw an error when a plugin has whitespace", function() {
+            assert.throws(function() {
+                StubbedPlugins.load("whitespace ");
+            }, /Whitespace found in plugin name 'whitespace '/);
+            assert.throws(function() {
+                StubbedPlugins.load("whitespace\t");
+            }, /Whitespace found in plugin name/);
+            assert.throws(function() {
+                StubbedPlugins.load("whitespace\n");
+            }, /Whitespace found in plugin name/);
+            assert.throws(function() {
+                StubbedPlugins.load("whitespace\r");
+            }, /Whitespace found in plugin name/);
+        });
+
         it("should throw an error when a plugin doesn't exist", function() {
             assert.throws(function() {
                 StubbedPlugins.load("nonexistentplugin");