Update: add fixer for wrap-regex (fixes #7013) #7048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@not-an-aardvark, thanks for your PR! By analyzing the annotation information on this pull request, we identified @michaelficarra, @vitorbal and @ilyavolodin to be potential reviewers |
kaicataldo
added
the
evaluating
mysticatea
removed
the
evaluating
|
LGTM but would like someone else to verify. |
|
LGTM |
|
LGTM as well, thanks @not-an-aardvark! Since this was open over the weekend, waiting one more day to merge in case anyone else decides to review. |
|
LGTM as well, thanks @not-an-aardvark! |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request address?
#7013
What changes did you make? (Give an overview)
This adds a fixer for the
wrap-regexrule by surrounding regular expressions literals with parentheses, as described in #7013.Is there anything you'd like reviewers to focus on?
Nothing in particular.
#7013 has not been accepted yet, so this PR should not be merged yet.