Update: no-magic-numbers false negative on reassigned vars (fixes #4616) #7028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@not-an-aardvark, thanks for your PR! By analyzing the annotation information on this pull request, we identified @kombucha, @vitorbal and @pmcelhaney to be potential reviewers |
|
LGTM |
|
This would be considered an "Update:" (trigger semver minor) rather than "Fix". Bug fixes that introduce new warnings are minor updates for us. |
|
Code LGTM, can you also update the rule docs? |
not-an-aardvark
force-pushed
the
issue4616
branch
from
36427f0
to
96b77cf
Compare
|
LGTM |
not-an-aardvark
changed the title
|
|
|
Lgtm. Thanks! |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request address?
#4616
What changes did you make? (Give an overview)
This causes
no-magic-numbersto report cases where variables are reassigned to magic numbers:Is there anything you'd like reviewers to focus on?
Since
no-magic-numbershad a test ensuring the opposite behavior, this might be considered a breaking change rather than a bugfix.