Core rule messages should use our template syntax and avoid concatenation

[platinumazure]

Goal is to make sure all rule messages that need runtime data use the {{ variable }} format and the data: key, rather than string concatenation or ES6 template literals.

[platinumazure]

Note; Discussion came up in chat about whether we should consider just using ES6 templates instead. At this point I just want to get all the rules into our "current"/"old" style before we consider a huge change like that (which would be breaking unless we supported the current form, anyway).

[kaicataldo]

I like the idea of doing this task as a prerequisite to #6407 (comment). We can use ES6 template literals everywhere else.

[platinumazure]

Working on this. I might just do the ES6 templates everywhere else in
lib/rules so that someone can use prefer-template to help make sure I
didn't miss any.

On Aug 25, 2016 9:56 PM, "Kai Cataldo" notifications@github.com wrote:

I like the idea of doing this task as a prerequisite to #6407 (comment)
#6407 (comment). We
can use ES6 template literals everywhere else.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#6977 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AARWelISSYiXnvNU2n5_cEdw-XC8WSQAks5qjlXEgaJpZM4Jtg74
.

[kaicataldo]

Great. I can work on the converting to template literals in other directories besides lib/rules.

[platinumazure]

PR up at #6989.

[gyandeeps]

Just curious, why are we just not going directly to template strings? (sorry if I missed the discussion)

[platinumazure]

@gyandeeps At this point, for no real reason besides following our own guidelines for how to write rules.

There's also issue #6740-- one benefit I could see from that issue is being able to show possible rule messages (with format placeholder) in CLI docs. That said, if there is a way to take a template string and render it as a string without interpolation, I wouldn't be opposed to using that format. I'm not super familiar with template strings, so maybe there is a way.

[mysticatea]

I prefer #6740 than ES templates because it's easier to support i18n 😇