Fix: Rule message placeholders can be inside braces (fixes #6988) #7041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
LGTM but would like someone else to verify. |
|
LGTM |
|
Lgtm, just waiting one more day. |
|
LGTM |
This was referenced Sep 3, 2016
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request address?
Issue #6988.
What changes did you make? (Give an overview)
Tightened up a regular expression to filter out brace characters from rule message parameters, since those are the delimiters used.
Is there anything you'd like reviewers to focus on?
Is this approach okay? I could also just have the first character not be an open brace, but I don't know if that's just more complexity for not a lot of gain.