Update: add fixer for new-parens (fixes #6994) (#7047)

eslint · Sep 6, 2016 · 657eee5 · 657eee5
1 parent ff19aa9
commit 657eee5
Show file tree

Hide file tree

Showing 3 changed files with 51 additions and 9 deletions.
diff --git a/docs/rules/new-parens.md b/docs/rules/new-parens.md
@@ -1,5 +1,7 @@
 # require parentheses when invoking a constructor with no arguments (new-parens)
 
+(fixable) The `--fix` option on the [command line](../user-guide/command-line-interface#fix) automatically fixes problems reported by this rule.
+
 JavaScript allows the omission of parentheses when invoking a function via the `new` keyword and the constructor has no arguments. However, some coders believe that omitting the parentheses is inconsistent with the rest of the language and thus makes code less clear.
 
 ```js

diff --git a/lib/rules/new-parens.js b/lib/rules/new-parens.js
@@ -55,7 +55,9 @@ module.exports = {
             recommended: false
         },
 
-        schema: []
+        schema: [],
+
+        fixable: "code"
     },
 
     create(context) {
@@ -73,7 +75,8 @@ module.exports = {
                 if (!(token && isOpeningParen(token) && isInRange(token, node))) {
                     context.report({
                         node,
-                        message: "Missing '()' invoking a constructor."
+                        message: "Missing '()' invoking a constructor.",
+                        fix: fixer => fixer.insertTextAfter(node, "()")
                     });
                 }
             }

diff --git a/tests/lib/rules/new-parens.js b/tests/lib/rules/new-parens.js
@@ -25,15 +25,52 @@ ruleTester.run("new-parens", rule, {
         "var a = new (Date)();",
         "var a = new ((Date))();",
         "var a = (new Date());",
+        "var a = new foo.Bar();",
+        "var a = (new Foo()).bar;",
     ],
     invalid: [
-        { code: "var a = new Date;", errors: [{ message: "Missing '()' invoking a constructor.", type: "NewExpression"}] },
-        { code: "var a = new Date", errors: [{ message: "Missing '()' invoking a constructor.", type: "NewExpression"}] },
-        { code: "var a = new (Date);", errors: [{ message: "Missing '()' invoking a constructor.", type: "NewExpression"}] },
-        { code: "var a = new (Date)", errors: [{ message: "Missing '()' invoking a constructor.", type: "NewExpression"}] },
-        { code: "var a = (new Date)", errors: [{ message: "Missing '()' invoking a constructor.", type: "NewExpression"}] },
+        {
+            code: "var a = new Date;",
+            output: "var a = new Date();",
+            errors: [{ message: "Missing '()' invoking a constructor.", type: "NewExpression" }]
+        },
+        {
+            code: "var a = new Date",
+            output: "var a = new Date()",
+            errors: [{ message: "Missing '()' invoking a constructor.", type: "NewExpression"}]
+        },
+        {
+            code: "var a = new (Date);",
+            output: "var a = new (Date)();",
+            errors: [{ message: "Missing '()' invoking a constructor.", type: "NewExpression"}]
+        },
+        {
+            code: "var a = new (Date)",
+            output: "var a = new (Date)()",
+            errors: [{ message: "Missing '()' invoking a constructor.", type: "NewExpression"}]
+        },
+        {
+            code: "var a = (new Date)",
+            output: "var a = (new Date())",
+            errors: [{ message: "Missing '()' invoking a constructor.",
+            type: "NewExpression"}]
+        },
+        {
 
-        // This `()` is `CallExpression`'s. This is a call of the result of `new Date`.
-        { code: "var a = (new Date)()", errors: [{ message: "Missing '()' invoking a constructor.", type: "NewExpression"}] },
+            // This `()` is `CallExpression`'s. This is a call of the result of `new Date`.
+            code: "var a = (new Date)()",
+            output: "var a = (new Date())()",
+            errors: [{ message: "Missing '()' invoking a constructor.", type: "NewExpression"}]
+        },
+        {
+            code: "var a = new foo.Bar;",
+            output: "var a = new foo.Bar();",
+            errors: [{ message: "Missing '()' invoking a constructor.", type: "NewExpression" }]
+        },
+        {
+            code: "var a = (new Foo).bar;",
+            output: "var a = (new Foo()).bar;",
+            errors: [{ message: "Missing '()' invoking a constructor.", type: "NewExpression" }]
+        }
     ]
 });