Fix: Allow separate mode option for multiline and align (fixes #6691) (…

…#6991)
eslint · Aug 30, 2016 · 256c4a2 · 256c4a2
1 parent a989a7c
commit 256c4a2
Show file tree

Hide file tree

Showing 2 changed files with 110 additions and 1 deletion.
diff --git a/lib/rules/key-spacing.js b/lib/rules/key-spacing.js
@@ -136,7 +136,7 @@ function initOptions(toOptions, fromOptions) {
         if (toOptions.multiLine.align) {
             toOptions.align = {
                 on: toOptions.multiLine.align.on,
-                mode: toOptions.multiLine.mode,
+                mode: toOptions.multiLine.align.mode || toOptions.multiLine.mode,
                 beforeColon: toOptions.multiLine.align.beforeColon,
                 afterColon: toOptions.multiLine.align.afterColon
             };
@@ -289,6 +289,9 @@ module.exports = {
                         multiLine: {
                             type: "object",
                             properties: {
+                                mode: {
+                                    enum: ["strict", "minimum"]
+                                },
                                 beforeColon: {
                                     type: "boolean"
                                 },

diff --git a/tests/lib/rules/key-spacing.js b/tests/lib/rules/key-spacing.js
@@ -711,6 +711,56 @@ ruleTester.run("key-spacing", rule, {
             }
         }],
         parserOptions: { ecmaVersion: 6, ecmaFeatures: { experimentalObjectRestSpread: true } }
+    }, {
+        code: [
+            "var obj = {",
+            "    key1: 1,",
+            "",
+            "    key2:    2,",
+            "    key3:    3,",
+            "",
+            "    key4: 4",
+            "}"
+        ].join("\n"),
+        options: [{
+            multiLine: {
+                beforeColon: false,
+                afterColon: true,
+                mode: "strict",
+                align: {
+                    beforeColon: false,
+                    afterColon: true,
+                    on: "colon",
+                    mode: "minimum"
+                }
+            }
+        }],
+        parserOptions: { ecmaVersion: 6, ecmaFeatures: { experimentalObjectRestSpread: true } }
+    }, {
+        code: [
+            "var obj = {",
+            "    key1: 1,",
+            "",
+            "    key2:    2,",
+            "    key3:    3,",
+            "",
+            "    key4: 4",
+            "}"
+        ].join("\n"),
+        options: [{
+            multiLine: {
+                beforeColon: false,
+                afterColon: true,
+                mode: "strict"
+            },
+            align: {
+                beforeColon: false,
+                afterColon: true,
+                on: "colon",
+                mode: "minimum"
+            }
+        }],
+        parserOptions: { ecmaVersion: 6, ecmaFeatures: { experimentalObjectRestSpread: true } }
     }],
 
     invalid: [{
@@ -1622,5 +1672,61 @@ ruleTester.run("key-spacing", rule, {
             { message: "Extra space before value for key \'func2\'.", line: 8, column: 16, type: "FunctionExpression" },
             { message: "Extra space after key \'singleLine\'.", line: 11, column: 5, type: "Identifier" }
         ]
+    }, {
+        code: [
+            "var obj = {",
+            "    key1: 1,",
+            "",
+            "    key2:    2,",
+            "    key3:    3,",
+            "",
+            "    key4: 4",
+            "}"
+        ].join("\n"),
+        options: [{
+            multiLine: {
+                beforeColon: false,
+                afterColon: true,
+                mode: "strict",
+                align: {
+                    beforeColon: false,
+                    afterColon: true,
+                    on: "colon",
+                }
+            }
+        }],
+        parserOptions: { ecmaVersion: 6, ecmaFeatures: { experimentalObjectRestSpread: true } },
+        errors: [
+            { message: "Extra space before value for key \'key2\'.", line: 4, column: 14, type: "Literal" },
+            { message: "Extra space before value for key \'key3\'.", line: 5, column: 14, type: "Literal" }
+        ]
+    }, {
+        code: [
+            "var obj = {",
+            "    key1: 1,",
+            "",
+            "    key2:    2,",
+            "    key3:    3,",
+            "",
+            "    key4: 4",
+            "}"
+        ].join("\n"),
+        options: [{
+            multiLine: {
+                beforeColon: false,
+                afterColon: true,
+                mode: "strict"
+            },
+            align: {
+                beforeColon: false,
+                afterColon: true,
+                on: "colon",
+            }
+        }],
+        parserOptions: { ecmaVersion: 6, ecmaFeatures: { experimentalObjectRestSpread: true } },
+        errors: [
+            { message: "Extra space before value for key \'key2\'.", line: 4, column: 14, type: "Literal" },
+            { message: "Extra space before value for key \'key3\'.", line: 5, column: 14, type: "Literal" }
+        ]
     }]
 });