Update: Pass file path to parse function

[annie]

ref: #5344

let me know if i need to update anything in the docs!

edit: moved the test into the "custom parser" describe since it was failing in the browser

[eslintbot]

Thanks for the pull request, @azhang496! I took a look to make sure it's ready for merging and found some changes are needed:

• Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

[eslintbot]

LGTM

[ilyavolodin]

LGTM, but waiting another day for others to look. Thanks @azhang496 for doing this!

[kaicataldo]

@ilyavolodin Any idea why the jQuery CLA check failed? @azhang496 has contributed before, so it was definitely working

[eslintbot]

LGTM

[platinumazure]

@kaicataldo The jQuery CLA status page is also giving HTTP 404, so I'm not sure what to do here. @kborchers Any ideas?

@azhang496 path.join doesn't exist in PhantomJS and browser environments, you might need to make sure your test is not run in Phantom.

[annie]

@platinumazure yep, moved the test into the custom parser section so it's not run in the browser

[kborchers]

Looking into this now and will update ASAP

[kborchers]

@azhang496 @platinumazure Sorry for the issue and delay but you should be all good now. There was a disk issue on the box that has now been resolved.

[nzakas]

LGTM, just waiting another day to fulfill our requirement that PRs remain open for two days so others have a chance to review.

[kaicataldo]

LGTM. Thanks for contributing to ESLint!

[platinumazure]

Thanks @kborchers for your help with the CLA.

[hzoo]

👍

[ilyavolodin]

Thanks @azhang496 for doing this!