Update: add fixer for no-floating-decimal (fixes #7070) (#7081)

eslint · Sep 9, 2016 · cec65e3 · cec65e3
1 parent 2a3f699
commit cec65e3
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 6 deletions.
diff --git a/docs/rules/no-floating-decimal.md b/docs/rules/no-floating-decimal.md
@@ -1,5 +1,7 @@
 # Disallow Floating Decimals (no-floating-decimal)
 
+(fixable) The `--fix` option on the [command line](../user-guide/command-line-interface#fix) automatically fixes problems reported by this rule.
+
 Float values in JavaScript contain a decimal point, and there is no requirement that the decimal point be preceded or followed by a number. For example, the following are all valid JavaScript numbers:
 
 ```js

diff --git a/lib/rules/no-floating-decimal.js b/lib/rules/no-floating-decimal.js
@@ -17,7 +17,9 @@ module.exports = {
             recommended: false
         },
 
-        schema: []
+        schema: [],
+
+        fixable: "code"
     },
 
     create(context) {
@@ -27,10 +29,18 @@ module.exports = {
 
                 if (typeof node.value === "number") {
                     if (node.raw.indexOf(".") === 0) {
-                        context.report(node, "A leading decimal point can be confused with a dot.");
+                        context.report({
+                            node,
+                            message: "A leading decimal point can be confused with a dot.",
+                            fix: fixer => fixer.insertTextBefore(node, "0")
+                        });
                     }
                     if (node.raw.indexOf(".") === node.raw.length - 1) {
-                        context.report(node, "A trailing decimal point can be confused with a dot.");
+                        context.report({
+                            node,
+                            message: "A trailing decimal point can be confused with a dot.",
+                            fix: fixer => fixer.insertTextAfter(node, "0")
+                        });
                     }
                 }
             }

diff --git a/tests/lib/rules/no-floating-decimal.js b/tests/lib/rules/no-floating-decimal.js
@@ -24,8 +24,25 @@ ruleTester.run("no-floating-decimal", rule, {
         "var x = \"2.5\";"
     ],
     invalid: [
-        { code: "var x = .5;", errors: [{ message: "A leading decimal point can be confused with a dot.", type: "Literal"}] },
-        { code: "var x = -.5;", errors: [{ message: "A leading decimal point can be confused with a dot.", type: "Literal"}] },
-        { code: "var x = 2.;", errors: [{ message: "A trailing decimal point can be confused with a dot.", type: "Literal"}] }
+        {
+            code: "var x = .5;",
+            output: "var x = 0.5;",
+            errors: [{ message: "A leading decimal point can be confused with a dot.", type: "Literal" }]
+        },
+        {
+            code: "var x = -.5;",
+            output: "var x = -0.5;",
+            errors: [{ message: "A leading decimal point can be confused with a dot.", type: "Literal" }]
+        },
+        {
+            code: "var x = 2.;",
+            output: "var x = 2.0;",
+            errors: [{ message: "A trailing decimal point can be confused with a dot.", type: "Literal" }]
+        },
+        {
+            code: "var x = -2.;",
+            output: "var x = -2.0;",
+            errors: [{ message: "A trailing decimal point can be confused with a dot.", type: "Literal" }]
+        }
     ]
 });