Fix: Return correct column number for no-multiple-empty-lines (fixes #7086)

[IanVS]

What issue does this pull request address?
#7086

What changes did you make? (Give an overview)
Changed column to be 0-based instead of 1-based

Is there anything you'd like reviewers to focus on?

[mention-bot]

@IanVS, thanks for your PR! By analyzing the annotation information on this pull request, we identified @vitorbal, @briandela and @RRMoelker to be potential reviewers

[eslintbot]

LGTM

[eslintbot]

LGTM

[platinumazure]

LGTM

[RRMoelker]

Interesting little bug. It would be a great addition if you also add a unit test for the problem:

• valid case: https://github.com/eslint/eslint/blob/master/tests/lib/rules/no-multiple-empty-lines.js#L156
• invalid case: https://github.com/eslint/eslint/blob/master/tests/lib/rules/no-multiple-empty-lines.js#L285

[IanVS]

Thanks for the review @RRMoelker. In fact, I updated all of the invalid cases by specifying the correct column number here: https://github.com/eslint/eslint/pull/7088/files#diff-4558020168345de2935e9798a1078aa9R51. That will cause the tests to fail without the fix.

[RRMoelker]

@IanVS Hmm, somehow missed that :). So: great, LGTM.

[eslintbot]

LGTM

[IanVS]

Actually, it was good you had me look at this again, I missed a few of the test helpers.

[nzakas]

LGTM