-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Return correct column number for no-multiple-empty-lines (fixes #7086) #7088
Conversation
@IanVS, thanks for your PR! By analyzing the annotation information on this pull request, we identified @vitorbal, @briandela and @RRMoelker to be potential reviewers |
LGTM |
LGTM |
1 similar comment
LGTM |
Interesting little bug. It would be a great addition if you also add a unit test for the problem: |
Thanks for the review @RRMoelker. In fact, I updated all of the invalid cases by specifying the correct column number here: https://github.com/eslint/eslint/pull/7088/files#diff-4558020168345de2935e9798a1078aa9R51. That will cause the tests to fail without the fix. |
@IanVS Hmm, somehow missed that :). So: great, LGTM. |
LGTM |
Actually, it was good you had me look at this again, I missed a few of the test helpers. |
LGTM |
What issue does this pull request address?
#7086
What changes did you make? (Give an overview)
Changed column to be 0-based instead of 1-based
Is there anything you'd like reviewers to focus on?