New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Update the example of SwitchCase #6981
Conversation
@vv314, thanks for your PR! By analyzing the annotation information on this pull request, we identified @Trott, @scriptdaemon and @valorkin to be potential reviewers |
LGTM |
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
On the Travis failure: You/we may want to consider removing Node.js 5 from the tests, as it's not a version Node.js supports anymore. Currently-supported versions are:
|
The |
LGTM |
@Trott You are right |
LGTM, just want a second opinion. Thanks for contributing! |
LGTM (although I'm not sure if my LGTM counts for anything or not as I'm not an ESLint team member or whatever...but it LGTM!) |
Apologies @Trott, I did mean from another team member-- but thanks for taking a look anyway! 😄 We appreciate contributions of any kind. |
Because the indentation is specified to
2
. For beginners, It will be better if setSwitchCase
to1
.