Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update the example of SwitchCase #6981

Merged
merged 2 commits into from Aug 27, 2016

Conversation

vv314
Copy link
Contributor

@vv314 vv314 commented Aug 26, 2016

Because the indentation is specified to 2. For beginners, It will be better if set SwitchCase to 1.

@mention-bot
Copy link

@vv314, thanks for your PR! By analyzing the annotation information on this pull request, we identified @Trott, @scriptdaemon and @valorkin to be potential reviewers

@eslintbot
Copy link

LGTM

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@Trott
Copy link
Contributor

Trott commented Aug 26, 2016

On the Travis failure: You/we may want to consider removing Node.js 5 from the tests, as it's not a version Node.js supports anymore. Currently-supported versions are:

  • 0.10.x (until October IIRC)
  • 0.12.x (until December IIRC)
  • 4.x.x
  • 6.x.x

@Trott
Copy link
Contributor

Trott commented Aug 26, 2016

The tabs -> tab change looks good to me. The other change is OK I guess but I think I'd prefer to see the new example added to the list instead of changing the existing example.

@alberto
Copy link
Member

alberto commented Aug 26, 2016

@Trott re: node@5, we decided against it: #6743

@eslintbot
Copy link

LGTM

@vv314
Copy link
Contributor Author

vv314 commented Aug 27, 2016

@Trott You are right

@platinumazure
Copy link
Member

LGTM, just want a second opinion. Thanks for contributing!

@Trott
Copy link
Contributor

Trott commented Aug 27, 2016

LGTM (although I'm not sure if my LGTM counts for anything or not as I'm not an ESLint team member or whatever...but it LGTM!)

@platinumazure
Copy link
Member

Apologies @Trott, I did mean from another team member-- but thanks for taking a look anyway! 😄 We appreciate contributions of any kind.

@gyandeeps gyandeeps merged commit 28f1619 into eslint:master Aug 27, 2016
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants