Update: Add "consistent" option to array-bracket-newline (#9136) #9206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@EthanRutherford, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aladdin-add and @JPeer264 to be potential reviewers. |
not-an-aardvark
added
enhancement
|
LGTM |
|
#9136 was accepted, so this should be ready for some review now. |
not-an-aardvark
added
accepted
not-an-aardvark
approved these changes
Oct 6, 2017
|
It looks like there is a merge conflict. |
EthanRutherford
force-pushed
the
ConsistentArrayBracketNewline
branch
from
dad11f6
to
48c7208
Compare
|
LGTM |
|
Merge conflict has been taken care of :) |
not-an-aardvark
approved these changes
Oct 6, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
#9136
What changes did you make? (Give an overview)
Added a "consistent" option to
array-bracket-newline