New: add consistent option to array-bracket-newline rule (fixes #9136) #9391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
LGTM |
|
LGTM |
VictorHom
changed the title
not-an-aardvark
added
accepted
|
LGTM |
|
LGTM |
|
Thanks for the PR! Is this the same as #9206? |
|
Yeps looks that way. Didn't realize it. Closing |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
most tests are based on https://eslint.org/docs/rules/object-curly-newline
their implementation and tests are very similar.
[X] Changes an existing rule ([template]
What rule do you want to change?**
array-bracket-newline rule
Does this change cause the rule to produce more or fewer warnings?
More warnings depending on how you configure the options
How will the change be implemented? (New option, new default behavior, etc.)?
New option