Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Add "consistent" option to array-bracket-newline #9136

Closed
EthanRutherford opened this issue Aug 21, 2017 · 7 comments
Closed

Update: Add "consistent" option to array-bracket-newline #9136

EthanRutherford opened this issue Aug 21, 2017 · 7 comments
Assignees
@platinumazure
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules

Comments

@EthanRutherford
Copy link
Contributor

EthanRutherford commented Aug 21, 2017 •
edited

object-curly-newline (https://eslint.org/docs/rules/object-curly-newline)
and the soon to be merged function-paren-newline (#8102 (comment))
both support the "consistent" option, allowing users to either use a newline on both or neither end.

array-bracket-newline ought to have a similar option, as it is a similar rule.
@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label Aug 21, 2017
@kaicataldo
Copy link
Member

kaicataldo commented Aug 23, 2017 •
edited

Just to be clear, did you mean the "soon to be merged function-paren-newline" rule?

If so, yes, this seems like a reasonable addition to me! 👍

@kaicataldo kaicataldo added enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Aug 23, 2017
@EthanRutherford
Copy link
Contributor Author

Yep, I'll correct that typo.

EthanRutherford added a commit to EthanRutherford/eslint that referenced this issue Sep 2, 2017
@EthanRutherford
Update: Add "consistent" option to array-bracket-newline (eslint#9136)
f785dcb
@EthanRutherford EthanRutherford mentioned this issue Sep 2, 2017
Merged
@platinumazure
Copy link
Member

@eslint/eslint-team This needs a champion and one more 👍 to be accepted, any takers?

@EthanRutherford
Copy link
Contributor Author

Still need a champion.

@platinumazure
Copy link
Member

I'll champion, but then we need one more 👍.

@eslint/eslint-team This is a pretty straightforward enhancement request, should be a shoe-in. Anyone else want to support this?

@platinumazure platinumazure self-assigned this Sep 14, 2017
@btmills btmills added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Sep 24, 2017
@btmills
Copy link
Member

btmills commented Sep 24, 2017

Just added my 👍. This is now accepted!

VictorHom added a commit to VictorHom/eslint that referenced this issue Oct 5, 2017
@VictorHom
New: add consistent option to rule (fixes eslint#9136)
0f2026e
@EthanRutherford
Copy link
Contributor Author

#9206

EthanRutherford added a commit to EthanRutherford/eslint that referenced this issue Oct 6, 2017
@EthanRutherford
Update: Add "consistent" option to array-bracket-newline (eslint#9136)
48c7208
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 5, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@platinumazure platinumazure

Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@platinumazure @btmills @EthanRutherford @kaicataldo @eslintbot