Chore: use eslint-plugin-rulesdir instead of --rulesdir for self-linting #9164
Conversation
not-an-aardvark
added
chore
|
LGTM |
|
@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mysticatea, @aladdin-add and @btmills to be potential reviewers. |
not-an-aardvark
force-pushed
the
use-eslint-plugin-rulesdir
branch
from
d77cd88
to
41ab1aa
Compare
|
LGTM |
| "eslint-plugin/prefer-placeholders": "error", | ||
| "eslint-plugin/report-message-format": ["error", "[^a-z].*\\.$"], | ||
| "eslint-plugin/test-case-property-ordering": "error", | ||
| "eslint-plugin/test-case-shorthand-strings": "error" |
There was a problem hiding this comment.
"eslint-plugin/no-identical-tests" has been added in recommended.
There was a problem hiding this comment.
Good catch, but I think we should remove it in a separate PR -- this PR is only supposed to change the format of the config file without modifying how it works.
There was a problem hiding this comment.
it has been removed in the master. so I think better not to add it again.
There was a problem hiding this comment.
Oh, oops. I hadn't realized that it was removed on master.
| @@ -1,3 +1,3 @@ | |||
| rules: | |||
| internal-no-invalid-meta: "error" | |||
| internal-consistent-docs-description: "error" | |||
| rulesdir/no-invalid-meta: "error" | |||
There was a problem hiding this comment.
what about change this to .eslintrc.js -- for consistency.
There was a problem hiding this comment.
¯\_(ツ)_/¯ I'm fine with this, but I was assuming people would prefer to keep files as .yml wherever possible, and only use .js config files when necessary.
|
LGTM |
not-an-aardvark
force-pushed
the
use-eslint-plugin-rulesdir
branch
from
27bd80d
to
f403913
Compare
|
LGTM |
not-an-aardvark
force-pushed
the
use-eslint-plugin-rulesdir
branch
from
f403913
to
98a3685
Compare
|
LGTM |
|
LGTM |
eslint-deprecated
bot
added
the
archived due to age
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
This updates our internal linting build to use
eslint-plugin-rulesdirrather than the--rulesdirCLI flag.We've been talking about deprecating
rulesdirfor awhile, so I think it would be good for us to dogfood some of the alternatives for using project-specific linting rules.#9163 is another way of solving the same problem. This PR is mutually exclusive with #9163.
Is there anything you'd like reviewers to focus on?
We should choose between this approach and the approach in #9163. Which do you prefer?