Chore: use eslint-plugin-local instead of --rulesdir for self-linting

[not-an-aardvark]

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)

This updates our internal linting build to use eslint-plugin-local rather than the --rulesdir CLI flag.

We've been talking about deprecating rulesdir for awhile, so I think it would be good for us to dogfood some of the alternatives for using project-specific linting rules.

#9164 is another way of solving the same problem. This PR is mutually exclusive with #9164.

Is there anything you'd like reviewers to focus on?

We should choose between this approach and the approach in #9164. Which do you prefer?

[eslintbot]

LGTM

[mention-bot]

@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vitorbal, @gajus and @nzakas to be potential reviewers.

[gyandeeps]

Can we move .eslintplugin.js file to folder rather than polluting the base folder with so many files?

[not-an-aardvark]

No, unfortunately not. eslint-plugin-local just consists of module.exports = require('../../.eslintplugin'), so with this solution we would need to have .eslintplugin.js in the root directory.

[eslintbot]

LGTM

[eslintbot]

LGTM

[eslintbot]

LGTM

[eslintbot]

LGTM

[not-an-aardvark]

@eslint/eslint-team Any thoughts on this PR or #9164? I think we should accept one of them -- they would make it easier for new contributors (since editor integrations wouldn't report issues from --rulesdir), and they would help us dogfood the recommended approaches for project-specific linting rules.

edit: fixed incorrect PR link

[aladdin-add]

I'm slightly prefer that one (#9164), as .eslintplugin.js file in the root dir in this PR.

[not-an-aardvark]

I'm slightly prefer that one (#9163)

Did you mean to link to #9164 instead of #9163? #9163 is this PR.

[aladdin-add]

yes~(⌒▽⌒)

it's because the PR you mentioned:

@eslint/eslint-team Any thoughts on this PR or #9163?

[not-an-aardvark]

Closing because #9164 was merged.