Chore: use eslint-plugin-rulesdir instead of --rulesdir for self-lint…

…ing (#9164)

.eslintignore

@@ -8,3 +8,4 @@
 /tests/performance/**
 /tmp/**
 test.js
+!.eslintrc.js

.eslintrc.js

@@ -0,0 +1,29 @@
+"use strict";
+
+const path = require("path");
+const rulesDirPlugin = require("eslint-plugin-rulesdir");
+
+rulesDirPlugin.RULES_DIR = path.join(__dirname, "tools/internal-rules");
+
+module.exports = {
+    root: true,
+    plugins: [
+        "eslint-plugin",
+        "node",
+        "rulesdir"
+    ],
+    extends: [
+        "./packages/eslint-config-eslint/default.yml",
+        "plugin:node/recommended",
+        "plugin:eslint-plugin/recommended"
+    ],
+    rules: {
+        "eslint-plugin/consistent-output": "error",
+        "eslint-plugin/no-deprecated-context-methods": "error",
+        "eslint-plugin/prefer-output-null": "error",
+        "eslint-plugin/prefer-placeholders": "error",
+        "eslint-plugin/report-message-format": ["error", "[^a-z].*\\.$"],
+        "eslint-plugin/test-case-property-ordering": "error",
+        "eslint-plugin/test-case-shorthand-strings": "error"
+    }
+};

Makefile.js

@@ -73,7 +73,7 @@ const NODE = "node ", // intentional extra space
 
     // Utilities - intentional extra space at the end of each string
     MOCHA = `${NODE_MODULES}mocha/bin/_mocha `,
-    ESLINT = `${NODE} bin/eslint.js --rulesdir tools/internal-rules/ --report-unused-disable-directives `,
+    ESLINT = `${NODE} bin/eslint.js --report-unused-disable-directives `,
 
     // Files
     MAKEFILE = "./Makefile.js",
@@ -486,6 +486,12 @@ target.lint = function() {
         errors++;
     }
 
+    echo("Validating .eslintrc.js");
+    lastReturn = exec(`${ESLINT} .eslintrc.js`);
+    if (lastReturn.code !== 0) {
+        errors++;
+    }
+
     echo("Validating JSON Files");
     lodash.forEach(JSON_FILES, validateJsonFile);
 

lib/rules/.eslintrc.yml

@@ -1,3 +1,3 @@
 rules:
-    internal-no-invalid-meta: "error"
-    internal-consistent-docs-description: "error"
+    rulesdir/no-invalid-meta: "error"
+    rulesdir/consistent-docs-description: "error"

package.json

@@ -86,6 +86,7 @@
     "ejs": "^2.5.6",
     "eslint-plugin-eslint-plugin": "^1.2.0",
     "eslint-plugin-node": "^5.1.0",
+    "eslint-plugin-rulesdir": "^0.1.0",
     "eslint-release": "^0.10.1",
     "eslump": "1.6.0",
     "esprima": "^4.0.0",

tests/lib/cli-engine.js

@@ -588,7 +588,7 @@ describe("CLIEngine", () => {
 
             engine = new CLIEngine({
                 cwd: originalDir,
-                configFile: ".eslintrc.yml"
+                configFile: ".eslintrc.js"
             });
 
             const report = engine.executeOnFiles(["lib/cli*.js"]);
@@ -602,7 +602,7 @@ describe("CLIEngine", () => {
 
             engine = new CLIEngine({
                 cwd: originalDir,
-                configFile: ".eslintrc.yml"
+                configFile: ".eslintrc.js"
             });
 
             const report = engine.executeOnFiles(["lib/cli*.js", "lib/cli.?s", "lib/{cli,cli-engine}.js"]);

tests/tools/internal-rules/internal-consistent-docs-description.js → tests/tools/internal-rules/consistent-docs-description.js

@@ -9,7 +9,7 @@
 // Requirements
 //------------------------------------------------------------------------------
 
-const rule = require("../../../tools/internal-rules/internal-consistent-docs-description"),
+const rule = require("../../../tools/internal-rules/consistent-docs-description"),
     RuleTester = require("../../../lib/testers/rule-tester");
 
 //------------------------------------------------------------------------------
@@ -18,7 +18,7 @@ const rule = require("../../../tools/internal-rules/internal-consistent-docs-des
 
 const ruleTester = new RuleTester();
 
-ruleTester.run("internal-consistent-docs-description", rule, {
+ruleTester.run("consistent-docs-description", rule, {
     valid: [
 
         // wrong exports format: "internal-no-invalid-meta" reports this already

tests/tools/internal-rules/internal-no-invalid-meta.js → tests/tools/internal-rules/no-invalid-meta.js

@@ -9,7 +9,7 @@
 // Requirements
 //------------------------------------------------------------------------------
 
-const rule = require("../../../tools/internal-rules/internal-no-invalid-meta"),
+const rule = require("../../../tools/internal-rules/no-invalid-meta"),
     RuleTester = require("../../../lib/testers/rule-tester");
 
 //------------------------------------------------------------------------------
@@ -18,7 +18,7 @@ const rule = require("../../../tools/internal-rules/internal-no-invalid-meta"),
 
 const ruleTester = new RuleTester();
 
-ruleTester.run("internal-no-invalid-meta", rule, {
+ruleTester.run("no-invalid-meta", rule, {
     valid: [
 
         // context.report() call with no fix

tools/internal-rules/.eslintrc.yml

@@ -1,3 +1,3 @@
 rules:
-    internal-no-invalid-meta: "error"
-    internal-consistent-docs-description: "error"
+    rulesdir/no-invalid-meta: "error"
+    rulesdir/consistent-docs-description: "error"