Chore: Use object-shorthand batch 1 (Refs #6407) #6893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaicataldo
force-pushed
the
objectshorthand1
branch
from
6c63105
to
ff073fe
Compare
|
LGTM |
|
LGTM. Honestly, I have to say, I'm not a huge fan of object shorthand syntax. |
|
Oh really? Why is that? I love how concise it is :) |
|
Personal preferences, but like many of the new enhancement it's optimized for less typing. Unfortunately, it also makes it a lot harder to visual scan the code and get a rough idea of what's going on. Since you type the code once, but read it many many times, I honestly don't like anything like that (arrow functions, object shorthand, ASI, etc.) |
This was referenced Aug 12, 2016
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking this up into batches as per the discussion here: #6812
This is the first batch (everything outside of
/lib). I'll actually enable the rule in the final batch :)@eslint/eslint-team Will merge this after I get a few pairs of eyes on this. Discussed with @nzakas in Gitter and we decided to get these reviewed and merged without having to wait the full two days. Since this touches so many files, waiting even a few days can lead to merge conflicts.