Chore: Use object-shorthand batch 2 (refs #6407) #6897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaicataldo
force-pushed
the
objectshorthand2
branch
from
bbe5bf9
to
9637f94
Compare
|
LGTM |
| initializeConfig: /* istanbul ignore next */ function(callback) { | ||
| getConfigForStyleGuide, | ||
| processAnswers, | ||
| /* istanbul ignore next */initializeConfig(callback) { |
|
LGTM. I would hold off on the next batch, since it looks like we will have to do a patch release on Monday, and it's better to do patch releases with minimal amount of changes. |
|
@ilyavolodin Will do -thanks! |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First batch: #6893
Breaking this up into batches as per the discussion here: #6812
This is the second batch (everything in
/libexcept/lib/rules). I'll actually enable the rule in the final batch :)@eslint/eslint-team Will merge this after I get a few pairs of eyes on this. Discussed with @nzakas in Gitter and we decided to get these reviewed and merged without having to wait the full two days. Since this touches so many files, waiting even a few days can lead to merge conflicts.
Ported from the original PR:
Pretty straightforward, aside from two things:
/* istanbul ignore next */comment to work for the shorthand notation (see this issue in the Istanbul repo for more info)getas a shorthand property name. We actually saw a bug report for this very situation and decided against fixing it, so my solution was to just rename the function. Will comment the specific location in the code.