Remove callback from handleProtocols
#890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
force-pushed
the
remove/handle-protocols-callback
branch
from
d58cc52
to
6bd0a57
Compare
|
@websockets/admin WDYT? |
3rd-Eden
approved these changes
Nov 15, 2016
|
@lpinca Sorry, I thought I already pressed the merge button. |
|
No problem. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now
handleProtocolstakes a callback which must be called synchronously by the developer with two arguments: the outcome of the operation and the selected protocol.I think it makes sense to remove the callback argument and use the returned value instead.