Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.0 changelog #934

Closed
lpinca opened this issue Dec 12, 2016 · 6 comments
Closed

2.0.0 changelog #934

lpinca opened this issue Dec 12, 2016 · 6 comments

Comments

@lpinca
Copy link
Member

lpinca commented Dec 12, 2016

The release is not ready yet but I spent some time writing a changelog with the changes up until now. Here it is:

Breaking changes

The following breaking changes only apply if you required the mentioned classes
directly.

Features

Bug fixes

Can a native speaker take a look and check if my Itanglish is ok or if there is something that is not clear enough?

Thanks!

@lpinca lpinca changed the title ws 2.0.0 changelog 2.0.0 changelog Dec 12, 2016
@Nibbler999
Copy link
Member

There are some typos, but looks good otherwise:

checkServerIdentify should be checkServerIdentity
unconditinally should be unconditionally

@lpinca
Copy link
Member Author

lpinca commented Dec 15, 2016

Saved as draft under https://github.com/websockets/ws/releases, closing.

@lpinca lpinca closed this as completed Dec 15, 2016
@erikpukinskis
Copy link

erikpukinskis commented Feb 3, 2017

Disappointing to see you drop Node support! Won't be able to continue on in the 2.0 branch I suppose. Care too much about the installed base. ES6 continues to infect otherwise good projects.

@lpinca
Copy link
Member Author

lpinca commented Feb 4, 2017

@erikpukinskis you can fork and transpile via babel if you care about Node.js < 4.

@erikpukinskis
Copy link

erikpukinskis commented Feb 6, 2017

@lpinca That's a great idea! I hadn't thought of that. I'm just going to stay on the 1.0 branch for now, but yours is one of the (extremely) few low level libraries I rely on so I may eventually look into transpiling.

Thanks for your hard work. I think ES6 has destroyed the most powerful aspects of Javascript (simple build tools, ubiquitous runtime, small language) so I am very frustrated with module authors requiring the new heavier build architecture. If my comment seemed aggressive it's just that frustration coming out. ES6 is infecting the entire JavaScript world making it increasingly difficult to run true JavaScript applications.

But I really appreciate the time you've put into this module it is excellent.

Is there any plan for maintenance of the 1.0 branch? What would be a good place to watch for discussions of security updates?

@lpinca
Copy link
Member Author

lpinca commented Feb 6, 2017

If my comment seemed aggressive it's just that frustration coming out. ES6 is infecting the entire JavaScript world making it increasingly difficult to run JavaScript software. It's frustrating to have module authors over and over drop their support for JavaScript.

No problem, I understand and I partially agree but wanted or not ES6+ is the future and some features were really needed imo :)

Is there any plan for maintenance of the 1.0 branch?

I don't think so as I don't want to bang on the 1.0 drums any longer but other collaborators might disagree with me and come up with a plan to backport bug and security fixes to the 1.0 branch.

Thanks for sharing your opinion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants