Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unecessary input trigger with v-model #5589

Merged
merged 3 commits into from May 7, 2017

Conversation

posva
Copy link
Member

@posva posva commented May 3, 2017

Fix #5586

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@posva
Copy link
Member Author

posva commented May 5, 2017

ping @yyx990803 tell me if you want me to add tests for this
The regression is #5586

@yyx990803
Copy link
Member

A test case would be great.

@posva
Copy link
Member Author

posva commented May 5, 2017

@yyx990803 Done, although I have never done this kind of events so I'm definitely forgetting about something

@yyx990803 yyx990803 merged commit d52a499 into vuejs:dev May 7, 2017
@posva posva deleted the fix-composition branch May 7, 2017 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random event triggered on @input with v-model
4 participants