Skip to content

Commit

Permalink
Prevent unecessary input trigger with v-model (#5589)
Browse files Browse the repository at this point in the history
* Prevent unecessary input trigger with v-model

Fix #5586

* Add test for compositionend on v-model + @input

* [skip ci] Rename tests for compositionend
  • Loading branch information
posva authored and yyx990803 committed May 7, 2017
1 parent 9ac4c41 commit d52a499
Show file tree
Hide file tree
Showing 2 changed files with 47 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/platforms/web/runtime/directives/model.js
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,8 @@ function onCompositionStart (e) {
}

function onCompositionEnd (e) {
// prevent triggering an input event for no reason
if (!e.target.composing) return
e.target.composing = false
trigger(e.target, 'input')
}
Expand Down
45 changes: 45 additions & 0 deletions test/unit/features/directives/model-text.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -249,4 +249,49 @@ describe('Directive v-model text', () => {
}).$mount()
expect('You are binding v-model directly to a v-for iteration alias').toHaveBeenWarned()
})

it('does not trigger extra input events with single compositionend', () => {
const spy = jasmine.createSpy()
const vm = new Vue({
data: {
a: 'a'
},
template: '<input v-model="a" @input="onInput">',
methods: {
onInput (e) {
spy(e.target.value)
}
}
}).$mount()
console.log(spy.calls.count())
expect(spy.calls.count()).toBe(0)
vm.$el.value = 'b'
triggerEvent(vm.$el, 'input')
expect(spy.calls.count()).toBe(1)
triggerEvent(vm.$el, 'compositionend')
expect(spy.calls.count()).toBe(1)
})

it('triggers extra input on compositionstart + end', () => {
const spy = jasmine.createSpy()
const vm = new Vue({
data: {
a: 'a'
},
template: '<input v-model="a" @input="onInput">',
methods: {
onInput (e) {
spy(e.target.value)
}
}
}).$mount()
console.log(spy.calls.count())
expect(spy.calls.count()).toBe(0)
vm.$el.value = 'b'
triggerEvent(vm.$el, 'input')
expect(spy.calls.count()).toBe(1)
triggerEvent(vm.$el, 'compositionstart')
triggerEvent(vm.$el, 'compositionend')
expect(spy.calls.count()).toBe(2)
})
})

0 comments on commit d52a499

Please sign in to comment.