-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ruby 3.3 #11497
Merged
Merged
Add support for ruby 3.3 #11497
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b96c820
Add support for ruby 3.3
jeffsee55 2841749
Set SUPPORTED_RUBY_VERSION to 3.3
jeffsee55 d7b7738
Merge branch 'main' into add-ruby33-to-builder
jeffsee55 8745d8d
Try updating platform for one of the ruby tests
jeffsee55 d4bb1b7
Merge branch 'add-ruby33-to-builder' of https://github.com/vercel/ver…
jeffsee55 610eca0
Merge branch 'main' into add-ruby33-to-builder
TooTallNate 06840d7
Install webrick for Ruby 3.3
TooTallNate 1f52aba
.
TooTallNate e027324
Add AL2 test fixture
TooTallNate 3b1313e
Merge branch 'main' into add-ruby33-to-builder
TooTallNate 948a6a5
.
TooTallNate 7e54050
.
TooTallNate ab42ec1
.
TooTallNate 6240831
.
TooTallNate File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@vercel/ruby': patch | ||
--- | ||
|
||
Add support for Ruby 3.3 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,6 @@ | |
|
||
source "https://rubygems.org" | ||
|
||
ruby "~> 3.2.x" | ||
ruby "~> 3.3.x" | ||
|
||
gem "cowsay", "~> 0.3.0" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,6 @@ | |
|
||
source "https://rubygems.org" | ||
|
||
ruby "~> 3.2.x" | ||
ruby "~> 3.3.x" | ||
|
||
gem "cowsay", "~> 0.3.0" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,6 @@ | |
|
||
source "https://rubygems.org" | ||
|
||
ruby "~> 3.2.x" | ||
ruby "~> 3.3.x" | ||
|
||
gem "cowsay", "~> 0.3.0" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,7 @@ GEM | |
|
||
PLATFORMS | ||
x86_64-darwin-21 | ||
x86_64-linux | ||
|
||
DEPENDENCIES | ||
cowsay (~> 0.3.0) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
|
||
source "https://rubygems.org" | ||
|
||
ruby "~> 3.2.x" | ||
ruby "~> 3.3.x" | ||
|
||
gem "cowsay", "~> 0.3.0" | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't dig into this, but we probably need this value to change based on the build image (node 20 or not) we're using.
Ref: https://github.com/vercel/vercel/blob/add-ruby33-to-builder/packages/static-build/src/index.ts#L582
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not really critical. This value is used to determine the vendor path where the Gem deps will be installed to. If anything, we should revisit this to install into
.vercel/cache
instead.