Add support for ruby 3.3 #11497
Merged
Add support for ruby 3.3 #11497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffsee55
requested review from
TooTallNate,
EndangeredMassa,
trek,
onsclom and
erikareads
as code owners
🦋 Changeset detectedLatest commit: 6240831 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
EndangeredMassa
previously approved these changes
Apr 26, 2024
janory
reviewed
Apr 26, 2024
There was a problem hiding this comment.
Please don't forget about the SUPPORTED_RUBY_VERSION constant, otherwise the install command won't work properly.
| @@ -48,7 +48,7 @@ import { | |||
| import { getHugoUrl } from './utils/hugo'; | |||
| import { once } from 'events'; | |||
|
|
|||
| const SUPPORTED_RUBY_VERSION = '3.2.0'; | |||
| const SUPPORTED_RUBY_VERSION = '3.3.0'; | |||
There was a problem hiding this comment.
I didn't dig into this, but we probably need this value to change based on the build image (node 20 or not) we're using.
Ref: https://github.com/vercel/vercel/blob/add-ruby33-to-builder/packages/static-build/src/index.ts#L582
There was a problem hiding this comment.
It's not really critical. This value is used to determine the vendor path where the Gem deps will be installed to. If anything, we should revisit this to install into .vercel/cache instead.
TooTallNate
approved these changes
Apr 29, 2024
Merged
EndangeredMassa
pushed a commit
that referenced
this pull request
Apr 30, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/build-utils@8.0.0 ### Major Changes - Remove legacy `avoidTopLevelInstall` logic ([#11513](#11513)) ### Patch Changes - [build-utils] Add `VERCEL_PROJECT_PRODUCTION_URL` framework env var prefix ([#11506](#11506)) ## @vercel/ruby@2.1.0 ### Minor Changes - Add support for Ruby 3.3 ([#11497](#11497)) - Remove legacy `avoidTopLevelInstall` logic ([#11513](#11513)) ## vercel@34.1.5 ### Patch Changes - Updated dependencies \[[`763a6d107`](763a6d1), [`15475c8a2`](15475c8), [`21f5e7375`](21f5e73)]: - @vercel/ruby@2.1.0 - @vercel/build-utils@8.0.0 - @vercel/node@3.0.28 - @vercel/static-build@2.5.1 ## @vercel/client@13.2.2 ### Patch Changes - Updated dependencies \[[`15475c8a2`](15475c8), [`21f5e7375`](21f5e73)]: - @vercel/build-utils@8.0.0 ## @vercel/gatsby-plugin-vercel-builder@2.0.26 ### Patch Changes - Updated dependencies \[[`15475c8a2`](15475c8), [`21f5e7375`](21f5e73)]: - @vercel/build-utils@8.0.0 ## @vercel/node@3.0.28 ### Patch Changes - Updated dependencies \[[`15475c8a2`](15475c8), [`21f5e7375`](21f5e73)]: - @vercel/build-utils@8.0.0 ## @vercel/static-build@2.5.1 ### Patch Changes - Updated dependencies \[]: - @vercel/gatsby-plugin-vercel-builder@2.0.26 ## @vercel-internals/types@1.0.31 ### Patch Changes - Updated dependencies \[[`15475c8a2`](15475c8), [`21f5e7375`](21f5e73)]: - @vercel/build-utils@8.0.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
TooTallNate
added a commit
that referenced
this pull request
Apr 30, 2024
We accidentally committed a change which prevented the static-build e2e tests, so fixing that. Also reverting a change from #11497 which was causing issues with Ruby-based static site generators when using the AL2 build image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for ruby3.3 when using AL2023 (Node v20). No support for ruby3.3 on Node <20 planned.
Ruby integration tests will now running on AL2023