Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [restrict-template-expressions] allowNumber: true by default #2005

Merged
merged 1 commit into from May 10, 2020

Conversation

bradzacher
Copy link
Member

BREAKING CHANGE:

I forgot this as part of the recommended config changes

@bradzacher bradzacher added enhancement New feature or request breaking change This change will require a new major version to be released labels May 10, 2020
@bradzacher bradzacher added this to the 3.0.0 milestone May 10, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher force-pushed the v3-restrict-template-expressions-default branch from 5e24009 to 4147bf9 Compare May 10, 2020 21:08
@codecov
Copy link

codecov bot commented May 10, 2020

Codecov Report

Merging #2005 into v3 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##               v3    #2005   +/-   ##
=======================================
  Coverage   93.66%   93.66%           
=======================================
  Files         169      169           
  Lines        7653     7653           
  Branches     2187     2187           
=======================================
  Hits         7168     7168           
  Misses        228      228           
  Partials      257      257           
Flag Coverage Δ
#unittest 93.66% <ø> (ø)
Impacted Files Coverage Δ
...-plugin/src/rules/restrict-template-expressions.ts 100.00% <ø> (ø)

@bradzacher bradzacher merged commit 2f90a5b into v3 May 10, 2020
@bradzacher bradzacher deleted the v3-restrict-template-expressions-default branch May 10, 2020 21:16
bradzacher added a commit that referenced this pull request May 11, 2020
bradzacher added a commit that referenced this pull request May 14, 2020
bradzacher added a commit that referenced this pull request May 17, 2020
bradzacher added a commit that referenced this pull request May 21, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change This change will require a new major version to be released enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant