feat(eslint-plugin): [restrict-template-expressions] `allowNumber: tr…

…ue` by default (#2005)
typescript-eslint · May 21, 2020 · 643ec24 · 643ec24
1 parent 3626a67
commit 643ec24
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/packages/eslint-plugin/docs/rules/restrict-template-expressions.md b/packages/eslint-plugin/docs/rules/restrict-template-expressions.md
@@ -38,7 +38,7 @@ type Options = {
 };
 
 const defaults = {
-  allowNumber: false,
+  allowNumber: true,
   allowBoolean: false,
   allowAny: false,
   allowNullable: false,

diff --git a/packages/eslint-plugin/src/rules/restrict-template-expressions.ts b/packages/eslint-plugin/src/rules/restrict-template-expressions.ts
@@ -41,7 +41,11 @@ export default util.createRule<Options, MessageId>({
       },
     ],
   },
-  defaultOptions: [{}],
+  defaultOptions: [
+    {
+      allowNumber: true,
+    },
+  ],
   create(context, [options]) {
     const service = util.getParserServices(context);
     const typeChecker = service.program.getTypeChecker();

diff --git a/packages/eslint-plugin/tests/rules/restrict-template-expressions.test.ts b/packages/eslint-plugin/tests/rules/restrict-template-expressions.test.ts
@@ -206,6 +206,7 @@ ruleTester.run('restrict-template-expressions', rule, {
       code: `
         const msg = \`arg = \${123}\`;
       `,
+      options: [{ allowNumber: false }],
       errors: [
         {
           messageId: 'invalidType',
@@ -246,6 +247,7 @@ ruleTester.run('restrict-template-expressions', rule, {
         declare const arg: number;
         const msg = \`arg = \${arg}\`;
       `,
+      options: [{ allowNumber: false }],
       errors: [
         {
           messageId: 'invalidType',