core-js 3 errors fix #7051
Merged
core-js 3 errors fix #7051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… && ADD this plugin to manager & preview also upgrade webpack to v4.33.0 (not necessary)
ndelangen
added
bug
configuration babel / webpack
patch:yes
ndelangen
requested review from
alexandrebodin,
alterx,
danielduan,
igor-dv,
leonrodenburg,
naipath,
shilman,
stijnkoopal,
thomasbertet,
tmeasday and
usulpro
as code owners
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fix-core-js-shenanigans.storybook.now.sh |
shilman
approved these changes
Jun 11, 2019
This was referenced Jun 13, 2019
shilman
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6984 #6928
What I did
CHANGE to use corejs-upgrade-webpack-plugin over local implementation
ADD this plugin to manager & preview
optional:
Upgrade webpack to v4.33.0 (not really necessary, other then that I made the webpack plugin require the latest, I could lower that version range)
code for corejs-upgrade-webpack-plugin now lives here:
https://github.com/ndelangen/corejs-upgrade-webpack-plugin
This plugin does nothing if it can find core-js v2 references, if they cannot be found it enforces all code to use core-js 3. If THAT can't be found, it throws an error.