@storybook 5.1.1 is throwing an error on build #6984
Assignees
Labels
Milestone
Comments
|
I'm experiencing this same issue. System: |
|
@ChucKN0risK @JonathanSpeek For debugging purposes, can you try regenerating your lock file? |
|
@shilman I deleted my |
|
I deleted both |
|
Following. |
|
Does anybody have a repo that we could look at to try to debug? |
|
Unfortunately mine is a private repo 😬 |
|
Mine too 😔 |
|
After installing Thanks to this post: https://stackoverflow.com/a/55313456/3906770 |
|
Do you have got a custom webpack config possibly? |
|
Getting the same issue as well in our GatsbyJS project Dependencies {
"devDependencies": {
"@storybook/addon-actions": "5.1.1",
"@storybook/addon-links": "5.1.1",
"@storybook/addon-storyshots": "5.1.1",
"@storybook/addon-storyshots-puppeteer": "5.1.1",
"@storybook/addons": "5.1.1",
"@storybook/react": "5.1.1",
"@types/storybook__addon-actions": "^3.4.3",
"@types/storybook__react": "^4.0.2"
}
}Storybook config import React from "react";
import { configure, addDecorator, addParameters } from "@storybook/react";
import Reset from "../src/ui/Reset";
import { Box } from "../src/ui/layout";
function loadStories() {
const req = require.context("../src", true, /\.stories\.tsx$/);
req.keys().forEach(filename => req(filename));
}
addParameters({
options: {
showPanel: false
}
});
addDecorator(storyFn => (
<>
<Reset />
<Box gutterV={0.5} gutterH={0.5} layout="block">
{storyFn()}
</Box>
</>
));
configure(loadStories, module);Webpack config module.exports = ({ config }) => {
config.module.rules.push({
test: /\.tsx?$/,
use: [
{
loader: "awesome-typescript-loader",
options: {
transpileOnly: true,
useBabel: true,
babelCore: "@babel/core"
}
}
]
});
config.resolve.extensions.push(".ts", ".tsx");
return config;
}; |
|
I had similar situation too. I found my project had error about dependented This file above is only in I don't know well why this version defference happened though. I hope this helps. |
|
Similar situation here with me. Below are the details for repro. Hope it helps. package.json contains:- .storybook/webpack.config.js contains:- .storybook/config.js contains:- .storybook/addons.js contains:- |
|
As the OP said, I was trying to upgrade from Here's my Here's my Here's my |
|
I'm taking a look now whether I can fix this. I need all possible missing core-js modules/files listed, so please respond if you see one missing not listed yet:
I could also use a repo to reproduce this on. Current work around involves adding core-js with a < 3 version in your package.json |
|
@ndelangen I'm not sure if this is helpful: |
|
Unfortunately, reverting to <3 doesn't work for me. I've also deleted my |
|
Found a workaround:
back in business. |
|
I've also pulled-down what was a working repo as of 2 days ago, onto another machine and am facing these same issues. I'm not sure how that's happening (maybe I'm naive here) when I've specified versions of packages that were all previously working together. 🤷🏻♂️ |
|
Hey all @ndelangen is on the case here. If you have stack traces or public repros, please post them here to help the debugging process. 🙏 |
|
wish I could help more, but everything is private |
|
in my case it was because of |
|
@ndelangen let me know what else might be helpful. Here's what I get from |
|
I had to copy my Also, if you're having trouble with Babel, we have to specify a corejs version now. Here is my setup if that helps: .babelrc {
"plugins": [
["@babel/plugin-transform-runtime", {
"corejs": 2
}]
],
"presets": [
["@babel/preset-env", {
"corejs": 2,
"useBuiltIns": "usage"
}],
"@babel/preset-react"
]
}package.json "dependencies": {
"@babel/runtime-corejs2": "^7.4.5",
"core-js": "^2.6.9",
},
"devDependencies": {
"@babel/cli": "^7.4.4",
"@babel/core": "^7.4.5",
"@babel/plugin-transform-runtime": "^7.4.4",
"@babel/preset-env": "^7.4.5",
"@babel/preset-react": "^7.0.0",
"@babel/register": "^7.4.4"
}, |
|
Looks like something is happening in the core-js project around that message that gets logged 20x |
|
I'm using react-native storybook, and just upgraded from v4 to v5 with the following steps: Then @storybook/react-native-server also gave me the same error in the issue reported at the top. |
|
Huzzah!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.1.5 containing PR #7086 that references this issue. Upgrade today to try it out! Closing this issue. Please re-open if you think there's still more to do. |
|
Still got these errors in the console after upgrading to |
|
@shilman Hit by this as well (5.1.8), using |
|
@dperetti Not familiar with |
|
@nategreen I do not know how flatten works, if you can debug what it does, and why it breaks the setup we'd welcome a PR! |
|
@dperetti Why would you set Maybe that might work if you run storybook without dll ( |
|
@ndelangen because I'm using Electron with a super recent Chromium that doesn't require any polyfill. |
|
Cool, but storybook isn't running in Electron though, is it? Our code assumes to be running in a browser, and we try to support browser down to IE11. Could you post your error + stacktrace? |
|
My Storybook is :-) #1435 (comment). |
|
Version 5.1.8 - fresh install as in my comment above: Errors: package.json |
|
#6204 @mwager similar problem here #6204 (comment). |
|
I worked around now by copying ALL the contents from core-js@2.6.5 |
|
A fix which works for us now (also on CI): Upgrade vue cli: See release notes: |
|
Awesome! Vue upgraded as well 🎊 |
|
@dperetti please do. Right an evergreen only project is easier then a non-evergreen project. |
and thousands of lines like this |
|
We're still experiencing this issue. Interestingly it works on 5.0.11 and 5.2.0-alpha.23 but not 5.1.x. Here is a sample project setup for 5.1.9 that is broken if you have a chance to have a look. |
alechp
added a commit
to servexyz/react-native-expo-storybook-v5
that referenced
this issue
Jun 26, 2019
|
here too on latest but everything is working fine in |
|
export ADBLOCK=1 && npm i |
|
Still experiencing same problem at |
|
+1 |
|
tnx @dimlksin2, your solution works |
|
i had the same webpack error on storybook |
|
I was banging my head against errors like this with storybook 6.1.11
and it was fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
Just upgraded to 5.1.1 from 5.0.1 and the build fails.
I downgraded to 5.0.1, removed my
nodes_modulesfolder and reinstall all my packages but the issues remain.I've never installed the
core-jspackage before and even after installing it the issues remain.System:
The text was updated successfully, but these errors were encountered: