Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce matching engines on npm install #481

Merged
merged 6 commits into from
Dec 30, 2019
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
- Ensures you are publishing from the `master` branch
- Ensures the working directory is clean and that there are no unpulled changes
- Reinstalls dependencies to ensure your project works with the latest dependency tree
- Checks that your Node.js and npm versions are supported by the project and its dependencies
sholladay marked this conversation as resolved.
Show resolved Hide resolved
- Runs the tests
- Bumps the version in package.json and npm-shrinkwrap.json (if present) and creates a git tag
- Prevents [accidental publishing](https://github.com/npm/npm/issues/13248) of pre-release versions under the `latest` [dist-tag](https://docs.npmjs.com/cli/dist-tag)
Expand Down
2 changes: 1 addition & 1 deletion source/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ module.exports = async (input = 'patch', options) => {
title: 'Installing dependencies using npm',
enabled: () => options.yarn === false,
task: () => {
const args = hasLockFile ? ['ci'] : ['install', '--no-package-lock', '--no-production'];
const args = hasLockFile ? ['ci'] : ['install', '--no-package-lock', '--no-production', '--engine-strict'];
itaisteinherz marked this conversation as resolved.
Show resolved Hide resolved
return exec('npm', args);
}
}
Expand Down