Enforce matching engines on npm install #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes. While there's no difference now, the problem might be fixed at some point, so it doesn't hurt to include it.
I wouldn't be surprised if this was the case. |
Co-Authored-By: Itai Steinherz <itaisteinherz@gmail.com>
It's currently a noop for `npm ci`, presumably because of an implementation quirk. But it's what we want to do, so we'll need to look into getting npm fixed.
|
All review feedback has been addressed. :) |
|
Thanks @sholladay! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #480
This PR enables the engine-strict configuration for
npm installwhen np reinstalls the dependencies. This will raise an error if the project or its dependencies have anengines.nodein package.json that are incompatible with the current environment.A question: should this be applied to the
npm cicase as well? I rannpm ci --engine-strictin a package whoseengines.nodewas incompatible with the current Node version and it did not complain, whereasnpm install --engine-strictdid complain in the same situation. However, I did not test what happens when dependencies have mismatched engines. I also did not test using the npm config environment variable, only the command line flag. Perhaps an implementation quirk leads tonpm ciloading configuration differently.