Deprecate common.getUserHome, advise using os.homedir instead #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #725 +/- ##
==========================================
+ Coverage 96.63% 96.71% +0.07%
==========================================
Files 33 33
Lines 1160 1156 -4
==========================================
- Hits 1121 1118 -3
+ Misses 39 38 -1
Continue to review full report at Codecov.
|
nfischer
requested changes
May 30, 2017
src/common.js
Outdated
| @@ -157,6 +158,8 @@ function ShellString(stdout, stderr, code) { | |||
|
|
|||
| exports.ShellString = ShellString; | |||
|
|
|||
| // DEPRECATED: Use os.homedir instead | |||
There was a problem hiding this comment.
Don't deprecate internal functions, just remove them. We only explicitly export the functions listed here:
nfischer
approved these changes
May 31, 2017
nfischer
pushed a commit
that referenced
this pull request
Jun 7, 2017
* Deprecate common.getUserHome, advise using os.homedir instead * Remove common.getUserHome
Merged
nfischer
pushed a commit
that referenced
this pull request
Jun 7, 2017
* Deprecate common.getUserHome, advise using os.homedir instead * Remove common.getUserHome
This was referenced Aug 29, 2019
This was referenced Mar 24, 2020
This was referenced Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates
common.getUserHomeand provides a warning about the deprecation. Also replaces all of the internal uses ofcommon.getUserHomewithos.homedir.Fixes #683