Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to os.homedir() when we move to v4+ #683

Closed
nfischer opened this issue Mar 5, 2017 · 3 comments
Closed

Switch to os.homedir() when we move to v4+ #683

nfischer opened this issue Mar 5, 2017 · 3 comments
Assignees
Labels
breaking Breaking change
Milestone

Comments

@nfischer
Copy link
Member

nfischer commented Mar 5, 2017

NodeJS added support for os.homedir() to get the user's home directory in a reliable way. When we drop support for v4, let's switch to that to reduce the amount of code we need to maintain.

@nfischer nfischer added the breaking Breaking change label Mar 5, 2017
@nfischer nfischer added this to the v0.8.0 milestone Mar 5, 2017
@freitagbr
Copy link
Contributor

If os.homedir is not reliant on native code, maybe we could polyfill it?

@nfischer
Copy link
Member Author

nfischer commented Mar 5, 2017

We already have our own implementation. I was suggesting we remove that implementation once we switch to v4+.

@nfischer
Copy link
Member Author

nfischer commented Jun 7, 2017

Already fixed in #725

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change
Projects
None yet
Development

No branches or pull requests

2 participants