Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AWS creds handling #7044

Merged
merged 2 commits into from Dec 4, 2019
Merged

Fix AWS creds handling #7044

merged 2 commits into from Dec 4, 2019

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Dec 4, 2019

Fixes #7013

Regression introduced with #6938

@medikoo medikoo added the bug label Dec 4, 2019
@medikoo medikoo added this to the 1.59.0 milestone Dec 4, 2019
@medikoo medikoo self-assigned this Dec 4, 2019
@codecov-io
Copy link

Codecov Report

Merging #7044 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #7044      +/-   ##
=========================================
+ Coverage   88.49%   88.5%   +<.01%     
=========================================
  Files         230     230              
  Lines        8466    8473       +7     
=========================================
+ Hits         7492    7499       +7     
  Misses        974     974
Impacted Files Coverage Δ
lib/plugins/aws/invokeLocal/index.js 76.92% <100%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a45d2a2...3561687. Read the comment docs.

Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@medikoo medikoo merged commit 4c1cee3 into master Dec 4, 2019
@medikoo medikoo deleted the fix-aws-creds-handling branch December 4, 2019 09:20
medikoo added a commit that referenced this pull request Dec 5, 2019
medikoo added a commit that referenced this pull request Dec 5, 2019
medikoo added a commit that referenced this pull request Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.58 was causing aws access keys to return as undefined
4 participants