Fix cached credentials mishandling #7054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medikoo
force-pushed
the
fix-cached-credentials-mishandling
branch
from
f9e27de
to
6380699
Compare
medikoo
force-pushed
the
fix-cached-credentials-mishandling
branch
from
6380699
to
d9cb40a
Compare
pmuens
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression introduced with #7044
Fixes #7050
It's based against
release-fast-trackwhich points last release, so we can release it as v1.59.1 (without taking any other stuff that was eventually merged to master after v1.59.0)Handling of
release-fast-trackbranch will be mostly automated shortly (I will prepare PR with CI config update today), still to not hold this, patch, I will issue v1.59.1 mostly manually now.After it's merged to
release-fast-track, I'll tag it on that branch and in result CI will automatically publish new version to npm, then I'd also ensure that it's merged into master and that release notes are added.