Correctly set default options for boolean flags #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 103 103
=====================================
Hits 103 103Continue to review full report at Codecov.
|
kentcdodds
reviewed
Jun 7, 2017
| @@ -112,10 +114,10 @@ const parser = yargs | |||
| - true - Example: { foo: bar } | |||
| - false - Example: {foo: bar} | |||
| `, | |||
| choices: [true, false], | |||
There was a problem hiding this comment.
I didn't make much sense when I added it in the previous commit. It's encouraged to be used as either --semi or --no-semi. Furthermore, yargs complains that undefined is not a valid choice (true or false).
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #71.
This is a follow-up to #63 where I removed the default values for some boolean flags (
semi,use-tabs,bracket-spacing,jsx-bracket-same-line,single-quote).yargs still sets the default value to
falseif the option is not present. This PR sets the default value toundefinedas per the documentation.