Unexpected changes to formatted result after bumping to v4

[robwise]

• prettier-eslint-cli version: 4.0.3
• prettier version: 1.4.2
• eslint version: 3.19.0

Relevant code/config.

// before
type foo = 'hello world';
type bar = { baz: null };

// after
type foo = "hello world";
type bar = {baz: null};

What you did: I bumped from 3.6.0 to 4.0.3 and ran the formatter. Reverting to 3.6.0 solves all of the below problems.

What happened:

• Flow annotations' quotations changed to double quotes
• Flow annotations lost bracket spacing
• Many instances of going over max line length when it didn't before. These cases aren't the usual instance where prettier formats it in a way that is below line length but then eslint fixes it in a way that is longer, these are cases where prettier should have wrapped itself before it even got to the eslint step.

I can't be sure, but it seems as though the prettier eslint inference isn't working right or something? And eslint --fix is covering it up (except for these issues)?

[kentcdodds]

I wonder whether this is related to the v6.2.1 release of prettier-eslint which was supposed to be non-breaking, but probably wasn't 🤔

[mrm007]

I got you.

[kentcdodds]

Merged! Thanks!