Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add missing namespaces to metadata #126

Merged
merged 4 commits into from Jun 15, 2018
Merged

Conversation

Rob--W
Copy link
Member

@Rob--W Rob--W commented Jun 5, 2018

I looked at the list of namespaces from #122 (comment) and added those which were missing to the metadata.

See the individual commit messages for more information.

With this PR (and #125), the metadata should be up-to-date, except for the privacy namespace.

Fixes #38

The auto-generated output from the metadata generator also includes the
following methods from Chrome. Firefox does not support them, so they
were not included in the metadata:

```
    "removeAppcache": {
      "minArgs": 1,
      "maxArgs": 1
    },
    "removeFileSystems": {
      "minArgs": 1,
      "maxArgs": 1
    },
    "removeIndexedDB": {
      "minArgs": 1,
      "maxArgs": 1
    },
    "removeWebSQL": {
      "minArgs": 1,
      "maxArgs": 1
    },
```

Also see:
https://searchfox.org/mozilla-central/rev/292d295d6b084b43b70de26a42e68513bb7b36a3/browser/components/extensions/schemas/browsing_data.json
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/browsingData#Browser_compatibility
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/sessions#Browser_compatibility

Only `sessions.getRecentlyClosed` and `sessions.restore` are currently
supported by Firefox.

`sessions.getDevices` is included anyway since this method may be added
to Firefox in the future: https://bugzil.la/1308059
@rpl rpl merged commit 4a407da into mozilla:master Jun 15, 2018
This was referenced Jun 15, 2018
notlmn added a commit to sindresorhus/notifier-for-github that referenced this pull request Jul 25, 2018
Closes #155, and #156

webextension-polyfill had most of the APIs to be promise based, but some of them (like permissions API) were only promisified in mozilla/webextension-polyfill#126 and broke the extension

I was too lazy to see webextion-polyfill packages release notes before updating to a newer version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants