Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more APIs to api-metadata #44

Closed
wants to merge 1 commit into from

Conversation

romantaraban
Copy link

Adding browser.permissions and browser.privacy.services.passwordSavingEnabled (https://bugzilla.mozilla.org/show_bug.cgi?id=1361364)

@fregante
Copy link
Contributor

fregante commented Nov 16, 2017

It looks like the build failed to start, can you try clicking on Restart build?

What's missing for this one to be merged?

@ExE-Boss
Copy link
Contributor

The permissions API is now present in the api‑metadata.json file, so this should be rebased.

"permissions": {
"contains": {
"minArgs": 1,
"maxArgs": 1
},
"getAll": {
"minArgs": 0,
"maxArgs": 0
},
"remove": {
"minArgs": 1,
"maxArgs": 1
},
"request": {
"minArgs": 1,
"maxArgs": 1
}
},

@rpl
Copy link
Member

rpl commented Jun 21, 2018

Closing this in favor of #133 which is going to add the missing privacy namespace and it also has some additional tests.

(the permissions namespace has been added in #126).

@rpl rpl closed this Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants