Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ignore explicit node_modules in package paths #799

Merged
merged 3 commits into from May 1, 2017

Conversation

evocateur
Copy link
Member

Description

  • When package globs have been configured with an explicit node_modules path, don't ignore **/node_modules/**
  • When no package globs have a globstar, don't ignore **/node_modules/**
  • When globstars exist in packages config, don't allow explicit node_modules paths

Motivation and Context

Fixes #792, based on discussion

How Has This Been Tested?

more unit tests to maintain coverage level

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@evocateur evocateur added this to the v2.0.0 milestone May 1, 2017
@evocateur evocateur changed the title Do not ignore explicitly configured node_modules in package paths Do not ignore explicitly configured node_modules package paths May 1, 2017
@evocateur evocateur changed the title Do not ignore explicitly configured node_modules package paths Do not ignore explicit node_modules in package paths May 1, 2017
@evocateur evocateur merged commit 7b72210 into lerna:master May 1, 2017
@evocateur evocateur deleted the allow-explicit-node-modules branch May 1, 2017 18:49
@lock
Copy link

lock bot commented Dec 27, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lerna does not find packages in non-default locations as of rc.4 - rc.3 works fine
1 participant