Do not ignore explicit node_modules in package paths (#799)

Fixes #792

src/PackageUtilities.js

@@ -51,12 +51,24 @@ export default class PackageUtilities {
       cwd: rootPath,
       strict: true,
       absolute: true,
-      ignore: [
+    };
+
+    const hasNodeModules = packageConfigs.some((cfg) => cfg.indexOf("node_modules") > -1);
+    const hasGlobStar = packageConfigs.some((cfg) => cfg.indexOf("**") > -1);
+
+    if (hasGlobStar) {
+      if (hasNodeModules) {
+        const message = "An explicit node_modules package path does not allow globstars (**)";
+        log.error("EPKGCONFIG", message);
+        throw new Error(message);
+      }
+
+      globOpts.ignore = [
         // allow globs like "packages/**",
         // but avoid picking up node_modules/**/package.json
         "**/node_modules/**",
-      ],
-    };
+      ];
+    }
 
     packageConfigs.forEach((globPath) => {
       glob.sync(path.join(globPath, "package.json"), globOpts)

test/PackageUtilities.js

@@ -40,6 +40,28 @@ describe("PackageUtilities", () => {
         "package-5",
       ]);
     });
+
+    it("does not ignore explicit node_modules in packages config", async () => {
+      const testDir = await initFixture("PackageUtilities/explicit-node-modules");
+      const result = PackageUtilities.getPackages(new Repository(testDir));
+      expect(result.map((pkg) => pkg.name)).toEqual([
+        "alle-pattern-monorepo",
+        "package-1",
+        "package-2",
+        "package-3",
+        "package-4",
+        "@scoped/package-5",
+      ]);
+    });
+
+    it("throws an error when globstars and explicit node_modules configs are mixed", async () => {
+      const testDir = await initFixture("PackageUtilities/mixed-globstar");
+      try {
+        PackageUtilities.getPackages(new Repository(testDir));
+      } catch (err) {
+        expect(err.message).toMatch("An explicit node_modules package path does not allow globstars");
+      }
+    });
   });
 
   describe(".filterPackages()", () => {

test/fixtures/PackageUtilities/explicit-node-modules/lerna.json

@@ -0,0 +1,9 @@
+{
+  "lerna": "__TEST_VERSION__",
+  "packages": [
+    "./",
+    "packages/node_modules/*",
+    "packages/node_modules/@scoped/*"
+  ],
+  "version": "1.0.0"
+}

test/fixtures/PackageUtilities/explicit-node-modules/package.json

@@ -0,0 +1,11 @@
+{
+  "name": "alle-pattern-monorepo",
+  "dependencies": {
+    "package-3": "^1.0.0",
+    "package-4": "^1.0.0"
+  },
+  "devDependencies": {
+    "lerna": "__TEST_VERSION__",
+    "@scoped/package-5": "^1.0.0"
+  }
+}

test/fixtures/PackageUtilities/mixed-globstar/lerna.json

@@ -0,0 +1,8 @@
+{
+  "lerna": "__TEST_VERSION__",
+  "packages": [
+    "src/**",
+    "packages/node_modules/*"
+  ],
+  "version": "1.0.0"
+}

test/fixtures/PackageUtilities/mixed-globstar/package.json

@@ -0,0 +1,7 @@
+{
+  "name": "mixed-globstar-monorepo",
+  "private": true,
+  "devDependencies": {
+    "lerna": "__TEST_VERSION__"
+  }
+}

test/fixtures/PackageUtilities/mixed-globstar/src/package-5/package.json

@@ -0,0 +1,7 @@
+{
+  "name": "package-5",
+  "version": "1.0.0",
+  "dependencies": {
+    "package-2": "^1.0.0"
+  }
+}