Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: add type of this to the not found handler #2102

Merged
merged 2 commits into from Feb 16, 2020
Merged

types: add type of this to the not found handler #2102

merged 2 commits into from Feb 16, 2020

Conversation

chengluyu
Copy link
Contributor

In the not found handler, this refers to the current fastify instance. However, corresponding type declaration of this is absent.

fastify/fastify.d.ts

Line 691 in b44d859

setNotFoundHandler(handler: (request: FastifyRequest<HttpRequest>, reply: FastifyReply<HttpResponse>) => void): void

This pull request contains the fix and corresponding test.

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

delvedor
delvedor approved these changes Feb 16, 2020
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor added the typescript TypeScript related label Feb 16, 2020
mcollina
mcollina approved these changes Feb 16, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 772cf5e into fastify:master Feb 16, 2020
@snyk-bot snyk-bot mentioned this pull request Mar 22, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 29, 2020
Closed
This was referenced Apr 12, 2020
Merged
Merged
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request May 5, 2020
Closed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@delvedor delvedor delvedor approved these changes

@Ethan-Arrowood Ethan-Arrowood Awaiting requested review from Ethan-Arrowood

Assignees
No one assigned
Labels
typescript TypeScript related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chengluyu @mcollina @delvedor