types: add type of this to the not found handler (#2102)

* add type of `this` to the not found handler * add test for previous commit
fastify · Feb 16, 2020 · 772cf5e · 772cf5e
1 parent b44d859
commit 772cf5e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/fastify.d.ts b/fastify.d.ts
@@ -688,7 +688,7 @@ declare namespace fastify {
     /**
      * Set the 404 handler
      */
-    setNotFoundHandler(handler: (request: FastifyRequest<HttpRequest>, reply: FastifyReply<HttpResponse>) => void): void
+    setNotFoundHandler(handler: (this: FastifyInstance<HttpServer, HttpRequest, HttpResponse>, request: FastifyRequest<HttpRequest>, reply: FastifyReply<HttpResponse>) => void): void
 
     /**
      * Set a function that will be called whenever an error happens

diff --git a/test/types/index.ts b/test/types/index.ts
@@ -505,7 +505,9 @@ server.get('/test-decorated-inputs', (req, reply) => {
   (reply as DecoratedReply).utility()
 })
 
-server.setNotFoundHandler((req, reply) => {
+server.setNotFoundHandler(function (req, reply) {
+  this.log.error('not found')
+  reply.code(404).send()
 })
 
 server.setErrorHandler((err, request, reply) => {