Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: incorrect error messages of no-unused-vars (fixes #9774) #9791

Merged
merged 1 commit into from Dec 30, 2017
Merged

Fix: incorrect error messages of no-unused-vars (fixes #9774) #9791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 8 additions & 13 deletions lib/rules/no-unused-vars.js
View file
Open in desktop
Expand Up @@ -105,26 +105,21 @@ module.exports = {
* @returns {string} The warning message to be used with this unused variable.
*/
function getDefinedMessage(unusedVar) {
const defType = unusedVar.defs && unusedVar.defs[0] && unusedVar.defs[0].type;
let type;
let pattern;

if (config.varsIgnorePattern) {
if (defType === "CatchClause" && config.caughtErrorsIgnorePattern) {
type = "args";
pattern = config.caughtErrorsIgnorePattern.toString();
} else if (defType === "Parameter" && config.argsIgnorePattern) {
type = "args";
pattern = config.argsIgnorePattern.toString();
} else if (defType !== "Parameter" && config.varsIgnorePattern) {
type = "vars";
pattern = config.varsIgnorePattern.toString();
}

if (unusedVar.defs && unusedVar.defs[0] && unusedVar.defs[0].type) {
const defType = unusedVar.defs[0].type;

if (defType === "CatchClause" && config.caughtErrorsIgnorePattern) {
type = "args";
pattern = config.caughtErrorsIgnorePattern.toString();
} else if (defType === "Parameter" && config.argsIgnorePattern) {
type = "args";
pattern = config.argsIgnorePattern.toString();
}
}

const additional = type ? ` Allowed unused ${type} must match ${pattern}.` : "";

return `'{{name}}' is defined but never used.${additional}`;
Expand Down
12 changes: 12 additions & 0 deletions tests/lib/rules/no-unused-vars.js
View file
Open in desktop
Expand Up @@ -675,6 +675,18 @@ ruleTester.run("no-unused-vars", rule, {
"'a' is defined but never used.",
"'c' is defined but never used."
]
},

// https://github.com/eslint/eslint/issues/9774
{
code: "(function(_a) {})();",
options: [{ args: "all", varsIgnorePattern: "^_" }],
errors: [{ message: "'_a' is defined but never used." }]
},
{
code: "(function(_a) {})();",
options: [{ args: "all", caughtErrorsIgnorePattern: "^_" }],
errors: [{ message: "'_a' is defined but never used." }]
}
]
});