Fix: incorrect error messages of no-unused-vars (fixes #9774) #9791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove varsIgnorePattern incorrectly included in error messages of no-unused-vars.
akouryy
changed the title
There was a problem hiding this comment.
Looks good. Could you please point me to a valid test where the argsIgnorePattern allows an unused argument, and also to an invalid test where the argsIgnorePattern shows up in the error message? (I assume these exist already but if they don't, please add them.) Thanks!
|
One of the former is https://github.com/eslint/eslint/blob/master/tests/lib/rules/no-unused-vars.js#L160 and one of the latter is https://github.com/eslint/eslint/blob/master/tests/lib/rules/no-unused-vars.js#L342. |
|
Thank you! I'll go ahead and approve. |
platinumazure
approved these changes
Dec 29, 2017
aladdin-add
added
accepted
aladdin-add
approved these changes
Dec 30, 2017
|
thanks for contributing! O(∩_∩)O |
This was referenced Mar 8, 2018
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
fixes #9774.
It showed
Allowed unused vars must match {varsIgnorePattern}.for an unused argument withoutargsIgnorePatternspecified.Is there anything you'd like reviewers to focus on?