Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Use XML 1.1 on XML formatters (fixes #9607) #9608

Merged
merged 1 commit into from Nov 26, 2017
Merged

Fix: Use XML 1.1 on XML formatters (fixes #9607) #9608

merged 1 commit into from Nov 26, 2017

Conversation

DReigada
Copy link
Contributor

@DReigada DReigada commented Nov 10, 2017 •
edited

What is the purpose of this pull request?

[x] Bug fix

This should fix the problem reported in #9607

What changes did you make? (Give an overview)
Changed all the XML headers to set the version to 1.1

@jsf-clabot
Copy link

jsf-clabot commented Nov 10, 2017 •
edited

CLA assistant check
All committers have signed the CLA.

@kaicataldo kaicataldo added breaking This change is backwards-incompatible bug ESLint is working incorrectly evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion formatter Relates to the formatters bundled with ESLint labels Nov 10, 2017
@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion and removed breaking This change is backwards-incompatible evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Nov 26, 2017
@not-an-aardvark
Copy link
Member

Removing the "breaking" label based on discussion in #9607.

@not-an-aardvark not-an-aardvark merged commit 208fb0f into eslint:master Nov 26, 2017
@not-an-aardvark
Copy link
Member

Thanks for contributing!

@platinumazure platinumazure mentioned this pull request Nov 29, 2017
Closed
platinumazure added a commit that referenced this pull request Nov 30, 2017
@platinumazure
Revert "Fix: Use XML 1.1 on XML formatters (fixes #9607) (#9608)"
afaa8d0 
This reverts commit 208fb0f.
@platinumazure platinumazure mentioned this pull request Nov 30, 2017
Merged
platinumazure added a commit that referenced this pull request Nov 30, 2017
@platinumazure
Revert "Fix: Use XML 1.1 on XML formatters (fixes #9607) (#9608)" (#9667
1e362a0 
)

This reverts commit 208fb0f.
@renovate renovate bot mentioned this pull request Feb 14, 2018
Merged
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators May 26, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label May 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly formatter Relates to the formatters bundled with ESLint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DReigada @jsf-clabot @not-an-aardvark @kaicataldo